chrome/browser/extensions/api/font_settings/font_settings_api.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/font_settings/font_settings_api.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/font_settings/font_settings_api.cc

diff --git a/chrome/browser/extensions/api/font_settings/font_settings_api.cc b/chrome/browser/extensions/api/font_settings/font_settings_api.cc

index b3e2457e5cc9210fb477e05f2c6af6ac9cd1f7c1..31f9f9d8003adf7ae82bf86eac4a4d183a9e31ba 100644

--- a/chrome/browser/extensions/api/font_settings/font_settings_api.cc

+++ b/chrome/browser/extensions/api/font_settings/font_settings_api.cc

@@ -301,7 +301,7 @@ bool FontSettingsGetFontListFunction::CopyFontsToResult(

for (base::ListValue::iterator it = fonts->begin();

it != fonts->end(); ++it) {

base::ListValue* font_list_value;

- if (!(*it)->GetAsList(&font_list_value)) {

+ if (!it->GetAsList(&font_list_value)) {

NOTREACHED();

return false;

}