chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc ('k') | chrome/browser/chromeos/platform_keys/key_permissions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

diff --git a/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc b/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

index 39a9d04d4dc6fe44fae7c3621e761e514dd079cc..4259daad5692f2de697e520dee69a1f530aa8fab 100644

--- a/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

+++ b/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

@@ -474,7 +474,7 @@ void OwnerSettingsServiceChromeOS::UpdateDeviceSettings(

entry != accounts_list->end();

++entry) {

const base::DictionaryValue* entry_dict = NULL;

- if ((*entry)->GetAsDictionary(&entry_dict)) {

+ if (entry->GetAsDictionary(&entry_dict)) {

em::DeviceLocalAccountInfoProto* account =

device_local_accounts->add_account();

std::string account_id;

@@ -572,7 +572,7 @@ void OwnerSettingsServiceChromeOS::UpdateDeviceSettings(

i != users->end();

++i) {

std::string email;

- if ((*i)->GetAsString(&email))

+ if (i->GetAsString(&email))

whitelist_proto->add_user_whitelist(email);

}

@@ -604,7 +604,7 @@ void OwnerSettingsServiceChromeOS::UpdateDeviceSettings(

i != flags->end();

++i) {

std::string flag;

- if ((*i)->GetAsString(&flag))

+ if (i->GetAsString(&flag))

flags_proto->add_flags(flag);

}