base/test/gtest_util.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/test/gtest_util.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/test/gtest_util.cc

diff --git a/base/test/gtest_util.cc b/base/test/gtest_util.cc

index 6da902da2e09859c1f0a2c4e039da0a50d31202b..1552c1a2500a50131528976889300ec6a62e87ea 100644

--- a/base/test/gtest_util.cc

+++ b/base/test/gtest_util.cc

@@ -85,7 +85,7 @@ bool ReadTestNamesFromFile(const FilePath& path,

std::vector<base::TestIdentifier> result;

for (base::ListValue::iterator i = tests->begin(); i != tests->end(); ++i) {

base::DictionaryValue* test = nullptr;

- if (!(*i)->GetAsDictionary(&test))

+ if (!i->GetAsDictionary(&test))

return false;

TestIdentifier test_data;

« no previous file with comments | « base/json/json_writer.cc ('k') | base/trace_event/trace_event_argument.cc » ('j') | no next file with comments »