components/policy/core/common/registry_dict.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/registry_dict.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/policy/core/common/registry_dict.cc

diff --git a/components/policy/core/common/registry_dict.cc b/components/policy/core/common/registry_dict.cc

index 29c9df73133d7ec59a75f9a95b936961b18a4f2e..2576d091b23c832b4d8344a71915b973019b7e71 100644

--- a/components/policy/core/common/registry_dict.cc

+++ b/components/policy/core/common/registry_dict.cc

@@ -62,7 +62,7 @@ std::unique_ptr<base::Value> ConvertValue(const base::Value& value,

for (base::ListValue::const_iterator entry(list->begin());

entry != list->end(); ++entry) {

std::unique_ptr<base::Value> converted =

- ConvertValue(**entry, schema.GetItems());

+ ConvertValue(*entry, schema.GetItems());

if (converted)

result->Append(std::move(converted));

}