components/policy/core/common/policy_loader_win_unittest.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/policy_loader_win_unittest.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/policy/core/common/policy_loader_win_unittest.cc

diff --git a/components/policy/core/common/policy_loader_win_unittest.cc b/components/policy/core/common/policy_loader_win_unittest.cc

index df67893b34a9731228488522055c5d167910990f..bb22d9939b02ef1d6f2e2b364f73dd208fa128ab 100644

--- a/components/policy/core/common/policy_loader_win_unittest.cc

+++ b/components/policy/core/common/policy_loader_win_unittest.cc

@@ -398,7 +398,7 @@ void RegistryTestHarness::InstallStringListPolicy(

element != policy_value->end();

++element) {

std::string element_value;

- if (!(*element)->GetAsString(&element_value))

+ if (!element->GetAsString(&element_value))

continue;

std::string name(base::IntToString(index++));

key.WriteValue(UTF8ToUTF16(name).c_str(),