components/policy/core/browser/configuration_policy_handler.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/browser/configuration_policy_handler.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/policy/core/browser/configuration_policy_handler.cc

diff --git a/components/policy/core/browser/configuration_policy_handler.cc b/components/policy/core/browser/configuration_policy_handler.cc

index 17de0cdd109f0373e6eed0c73ee618f23930172e..e591f99acc3fba8edafbc7b1623b1292a322b175 100644

--- a/components/policy/core/browser/configuration_policy_handler.cc

+++ b/components/policy/core/browser/configuration_policy_handler.cc

@@ -184,7 +184,7 @@ bool StringMappingListPolicyHandler::Convert(const base::Value* input,

for (auto entry = list_value->begin(); entry != list_value->end(); ++entry) {

std::string entry_value;

- if (!(*entry)->GetAsString(&entry_value)) {

+ if (!entry->GetAsString(&entry_value)) {

if (errors) {

errors->AddError(policy_name(), entry - list_value->begin(),

IDS_POLICY_TYPE_ERROR,