Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Unified Diff: components/ntp_snippets/remote/remote_suggestion.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/remote/remote_suggestion.cc
diff --git a/components/ntp_snippets/remote/remote_suggestion.cc b/components/ntp_snippets/remote/remote_suggestion.cc
index 714e016877a26696270fdbb68030e613ed318a95..57c8c646b6003da7f9b95eb4deb3ffa2775cdd7a 100644
--- a/components/ntp_snippets/remote/remote_suggestion.cc
+++ b/components/ntp_snippets/remote/remote_suggestion.cc
@@ -119,7 +119,7 @@ RemoteSuggestion::CreateFromChromeReaderDictionary(
std::vector<SnippetSource> sources;
for (const auto& value : *corpus_infos_list) {
const base::DictionaryValue* dict_value = nullptr;
- if (!value->GetAsDictionary(&dict_value)) {
+ if (!value.GetAsDictionary(&dict_value)) {
DLOG(WARNING) << "Invalid source info for article " << primary_id;
continue;
}
@@ -228,7 +228,7 @@ RemoteSuggestion::CreateFromContentSuggestionsDictionary(
std::vector<std::string> parsed_ids;
for (const auto& value : *ids) {
std::string id;
- if (!value->GetAsString(&id)) {
+ if (!value.GetAsString(&id)) {
return nullptr;
}
parsed_ids.push_back(id);

Powered by Google App Engine
This is Rietveld 408576698