components/ntp_snippets/category_rankers/click_based_category_ranker.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/category_rankers/click_based_category_ranker.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/browser_sync/profile_sync_service.cc ('K') | « components/flags_ui/pref_service_flags_storage.cc ('k') | components/ntp_snippets/content_suggestions_service.cc » ('j') | components/sync/driver/about_sync_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/category_rankers/click_based_category_ranker.cc

diff --git a/components/ntp_snippets/category_rankers/click_based_category_ranker.cc b/components/ntp_snippets/category_rankers/click_based_category_ranker.cc

index 653a68f9ac21908e49d30fa3134c833bb3da1bac..5dc8882fc08832399655a7a468ff6ee8a9b97b2a 100644

--- a/components/ntp_snippets/category_rankers/click_based_category_ranker.cc

+++ b/components/ntp_snippets/category_rankers/click_based_category_ranker.cc

@@ -413,9 +413,9 @@ bool ClickBasedCategoryRanker::ReadOrderFromPrefs(

return false;

}

- for (const std::unique_ptr<base::Value>& value : *list) {

- base::DictionaryValue* dictionary;

- if (!value->GetAsDictionary(&dictionary)) {

+ for (const base::Value& value : *list) {

+ const base::DictionaryValue* dictionary;

+ if (!value.GetAsDictionary(&dictionary)) {

LOG(DFATAL) << "Failed to parse category data from prefs param "

<< prefs::kClickBasedCategoryRankerOrderWithClicks

<< " into dictionary.";