components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/browser_sync/profile_sync_service.cc ('K') | « components/browser_sync/profile_sync_service.cc ('k') | components/error_page/common/localized_error.cc » ('j') | components/sync/driver/about_sync_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc

diff --git a/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc b/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc

index 8f7db517adb5fc1d1c4040a30ef041bcb43012d4..cbf28f53ae138314cf511e1db2135f86f01e768b 100644

--- a/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc

+++ b/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc

@@ -54,7 +54,7 @@ std::string JoinListValueStrings(base::ListValue* list_value) {

std::vector<std::string> values;

for (const auto& value : *list_value) {

std::string value_string;

- if (!value->GetAsString(&value_string))

+ if (!value.GetAsString(&value_string))

return std::string();

values.push_back(std::move(value_string));