Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3154)

Unified Diff: chrome/browser/extensions/policy_handlers.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/policy_handlers.cc
diff --git a/chrome/browser/extensions/policy_handlers.cc b/chrome/browser/extensions/policy_handlers.cc
index 8ee0bee34a419ddb771c3fac97b844ef885f3385..0b0b2bf14865b4250a3f3b9a6f8f1abea8a76d66 100644
--- a/chrome/browser/extensions/policy_handlers.cc
+++ b/chrome/browser/extensions/policy_handlers.cc
@@ -78,7 +78,7 @@ bool ExtensionListPolicyHandler::CheckAndGetList(
for (base::ListValue::const_iterator entry(list_value->begin());
entry != list_value->end(); ++entry) {
std::string id;
- if (!(*entry)->GetAsString(&id)) {
+ if (!entry->GetAsString(&id)) {
errors->AddError(policy_name(), entry - list_value->begin(),
IDS_POLICY_TYPE_ERROR,
base::Value::GetTypeName(base::Value::Type::STRING));
@@ -143,7 +143,7 @@ bool ExtensionInstallListPolicyHandler::ParseList(
for (base::ListValue::const_iterator entry(policy_list_value->begin());
entry != policy_list_value->end(); ++entry) {
std::string entry_string;
- if (!(*entry)->GetAsString(&entry_string)) {
+ if (!entry->GetAsString(&entry_string)) {
if (errors) {
errors->AddError(policy_name(), entry - policy_list_value->begin(),
IDS_POLICY_TYPE_ERROR,
@@ -230,7 +230,7 @@ bool ExtensionURLPatternListPolicyHandler::CheckPolicySettings(
for (base::ListValue::const_iterator entry(list_value->begin());
entry != list_value->end(); ++entry) {
std::string url_pattern_string;
- if (!(*entry)->GetAsString(&url_pattern_string)) {
+ if (!entry->GetAsString(&url_pattern_string)) {
errors->AddError(policy_name(), entry - list_value->begin(),
IDS_POLICY_TYPE_ERROR,
base::Value::GetTypeName(base::Value::Type::STRING));

Powered by Google App Engine
This is Rietveld 408576698