chrome/browser/extensions/install_signer.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/install_signer.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/install_signer.cc

diff --git a/chrome/browser/extensions/install_signer.cc b/chrome/browser/extensions/install_signer.cc

index 065a544b3c85799c3059c3f9dd9d312284f8de92..eb7dd01c2a18a9fc694fba96c72a72c00e41e7e5 100644

--- a/chrome/browser/extensions/install_signer.cc

+++ b/chrome/browser/extensions/install_signer.cc

@@ -145,7 +145,7 @@ bool GetExtensionIdSet(const base::DictionaryValue& dictionary,

i != id_list->end();

++i) {

std::string id;

- if (!(*i)->GetAsString(&id)) {

+ if (!i->GetAsString(&id)) {

return false;

}

ids->insert(id);