chrome/browser/devtools/devtools_window.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/devtools_window.cc

diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc

index e27d75baca923bad50827cb137dc6df58ebc7e23..e9157c5caf0b7ebc68224c8f4923f4709f635623 100644

--- a/chrome/browser/devtools/devtools_window.cc

+++ b/chrome/browser/devtools/devtools_window.cc

@@ -254,7 +254,7 @@ void DevToolsEventForwarder::SetWhitelistedShortcuts(

base::ListValue::iterator it = shortcut_list->begin();

for (; it != shortcut_list->end(); ++it) {

base::DictionaryValue* dictionary;

- if (!(*it)->GetAsDictionary(&dictionary))

+ if (!it->GetAsDictionary(&dictionary))

continue;

int key_code = 0;

dictionary->GetInteger("keyCode", &key_code);