Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1593)

Unified Diff: chrome/browser/devtools/device/devtools_device_discovery.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/device/devtools_device_discovery.cc
diff --git a/chrome/browser/devtools/device/devtools_device_discovery.cc b/chrome/browser/devtools/device/devtools_device_discovery.cc
index 184c5125a8e6ae944ca831088fc5a341cfd1c596..72c92c6dc4a61c734556db95b8019688aced6a32 100644
--- a/chrome/browser/devtools/device/devtools_device_discovery.cc
+++ b/chrome/browser/devtools/device/devtools_device_discovery.cc
@@ -483,8 +483,8 @@ void DevToolsDeviceDiscovery::DiscoveryRequest::ReceivedPages(
base::ListValue* list_value;
if (value && value->GetAsList(&list_value)) {
for (const auto& page_value : *list_value) {
- base::DictionaryValue* dict;
- if (page_value->GetAsDictionary(&dict))
+ const base::DictionaryValue* dict;
+ if (page_value.GetAsDictionary(&dict))
browser->pages_.push_back(
new RemotePage(device, browser->browser_id_, *dict));
}

Powered by Google App Engine
This is Rietveld 408576698