chrome/browser/chromeos/settings/cros_settings.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/settings/cros_settings.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/settings/cros_settings.cc

diff --git a/chrome/browser/chromeos/settings/cros_settings.cc b/chrome/browser/chromeos/settings/cros_settings.cc

index 91042aac401f18122c6cb7b0d17d67af08629b12..b49a02e4588d74d85b99bfde66ad3b8d6fe3dc79 100644

--- a/chrome/browser/chromeos/settings/cros_settings.cc

+++ b/chrome/browser/chromeos/settings/cros_settings.cc

@@ -245,7 +245,7 @@ bool CrosSettings::FindEmailInList(const std::string& path,

entry != list->end();

++entry) {

std::string entry_string;

- if (!(*entry)->GetAsString(&entry_string)) {

+ if (!entry->GetAsString(&entry_string)) {

NOTREACHED();

continue;

}