chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/values.cc ('K') | « chrome/browser/chromeos/platform_keys/key_permissions.cc ('k') | chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc » ('j') | chrome/browser/extensions/menu_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc

diff --git a/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc b/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc

index ded0f9f5967dccd99337bf98274cb1c5fa2e1420..dafa17dd96ccbfe1d04f00f704ad866272914f92 100644

--- a/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc

+++ b/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc

@@ -324,7 +324,7 @@ void PinnedLauncherAppsPolicyHandler::ApplyPolicySettings(

for (base::ListValue::const_iterator entry(policy_list->begin());

entry != policy_list->end(); ++entry) {

std::string id;

- if ((*entry)->GetAsString(&id)) {

+ if (entry->GetAsString(&id)) {

auto app_dict = base::MakeUnique<base::DictionaryValue>();

app_dict->SetString(ash::launcher::kPinnedAppsPrefAppIDPath, id);

pinned_apps_list->Append(std::move(app_dict));