chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/values.cc ('K') | « chrome/browser/chromeos/file_system_provider/registry.cc ('k') | chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc » ('j') | chrome/browser/extensions/menu_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.cc

diff --git a/chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.cc b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.cc

index 5e05e0856ac14b19846ad96765b0014a2ad45677..e39a3b3df5f4e2106b843418ddf0598548a9152f 100644

--- a/chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.cc

+++ b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.cc

@@ -184,7 +184,7 @@ bool EasyUnlockKeyManager::RemoteDeviceListToDeviceDataList(

it != device_list.end();

++it) {

const base::DictionaryValue* dict;

- if (!(*it)->GetAsDictionary(&dict) || !dict)

+ if (!it->GetAsDictionary(&dict) || !dict)

return false;

EasyUnlockDeviceKeyData data;