chrome/browser/android/vr_shell/ui_scene.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/vr_shell/ui_scene.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/vr_shell/ui_scene.cc

diff --git a/chrome/browser/android/vr_shell/ui_scene.cc b/chrome/browser/android/vr_shell/ui_scene.cc

index f07076f8066683b9a7a4c5674883f99c8dbbea96..369a7f32a5cd365d3321a228e61f7ca53d0156f3 100644

--- a/chrome/browser/android/vr_shell/ui_scene.cc

+++ b/chrome/browser/android/vr_shell/ui_scene.cc

@@ -293,7 +293,7 @@ void UiScene::HandleCommands(std::unique_ptr<base::ListValue> commands,

int64_t time_in_micro) {

for (auto& item : *commands) {

base::DictionaryValue* dict;

- CHECK(item->GetAsDictionary(&dict));

+ CHECK(item.GetAsDictionary(&dict));

Command type;

base::DictionaryValue* data;