Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1760)

Unified Diff: base/values_unittest.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/values_unittest.cc
diff --git a/base/values_unittest.cc b/base/values_unittest.cc
index 3bcdc16e37e61919d59ea81a8088572f24e94c43..e7df6258a184b45fb7ef9c8c3d97d56a30e0e200 100644
--- a/base/values_unittest.cc
+++ b/base/values_unittest.cc
@@ -421,7 +421,7 @@ TEST(ValuesTest, List) {
base::Value not_found_value(false);
ASSERT_NE(mixed_list->end(), mixed_list->Find(sought_value));
- ASSERT_TRUE((*mixed_list->Find(sought_value))->GetAsInteger(&int_value));
+ ASSERT_TRUE((*mixed_list->Find(sought_value)).GetAsInteger(&int_value));
ASSERT_EQ(42, int_value);
ASSERT_EQ(mixed_list->end(), mixed_list->Find(not_found_value));
}
@@ -524,10 +524,10 @@ TEST(ValuesTest, ListRemoval) {
{
ListValue list;
auto value = MakeUnique<Value>();
- Value* original_value = value.get();
+ Value original_value = *value;
list.Append(std::move(value));
size_t index = 0;
- list.Remove(*original_value, &index);
+ list.Remove(original_value, &index);
EXPECT_EQ(0U, index);
EXPECT_EQ(0U, list.GetSize());
}

Powered by Google App Engine
This is Rietveld 408576698