base/trace_event/trace_event_memory_overhead.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/trace_event_memory_overhead.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Comment Updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/trace_event/trace_event_memory_overhead.cc

diff --git a/base/trace_event/trace_event_memory_overhead.cc b/base/trace_event/trace_event_memory_overhead.cc

index 8d56e1d80e8d05a7d155a2a91e424ff8a7723a25..40d698cc1a6e4d02044d124db78a7363866f8c88 100644

--- a/base/trace_event/trace_event_memory_overhead.cc

+++ b/base/trace_event/trace_event_memory_overhead.cc

@@ -105,7 +105,7 @@ void TraceEventMemoryOverhead::AddValue(const Value& value) {

value.GetAsList(&list_value);

Add("ListValue", sizeof(ListValue));

for (const auto& v : *list_value)

- AddValue(*v);

+ AddValue(v);

} break;

default: