Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2915)

Unified Diff: ash/display/json_converter.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/json/json_writer.cc » ('j') | base/values.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/display/json_converter.cc
diff --git a/ash/display/json_converter.cc b/ash/display/json_converter.cc
index 943eeb44a358e90ceb5b79b34c863aa592d4ea2b..7b066faa5e167c134f67b4b540e1a1f4896d1c2e 100644
--- a/ash/display/json_converter.cc
+++ b/ash/display/json_converter.cc
@@ -126,7 +126,7 @@ bool UpdateFromDict(const base::DictionaryValue* dict_value,
output->reserve(list->GetSize());
for (const auto& list_item : *list) {
const base::DictionaryValue* item_values = nullptr;
- if (!list_item->GetAsDictionary(&item_values))
+ if (!list_item.GetAsDictionary(&item_values))
return false;
display::DisplayPlacement item;
« no previous file with comments | « no previous file | base/json/json_writer.cc » ('j') | base/values.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698