Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Side by Side Diff: chrome/browser/extensions/install_signer.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Fix Android Compilation Error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/install_signer.h" 5 #include "chrome/browser/extensions/install_signer.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 bool GetExtensionIdSet(const base::DictionaryValue& dictionary, 138 bool GetExtensionIdSet(const base::DictionaryValue& dictionary,
139 const char* key, 139 const char* key,
140 ExtensionIdSet* ids) { 140 ExtensionIdSet* ids) {
141 const base::ListValue* id_list = NULL; 141 const base::ListValue* id_list = NULL;
142 if (!dictionary.GetList(key, &id_list)) 142 if (!dictionary.GetList(key, &id_list))
143 return false; 143 return false;
144 for (base::ListValue::const_iterator i = id_list->begin(); 144 for (base::ListValue::const_iterator i = id_list->begin();
145 i != id_list->end(); 145 i != id_list->end();
146 ++i) { 146 ++i) {
147 std::string id; 147 std::string id;
148 if (!(*i)->GetAsString(&id)) { 148 if (!i->GetAsString(&id)) {
149 return false; 149 return false;
150 } 150 }
151 ids->insert(id); 151 ids->insert(id);
152 } 152 }
153 return true; 153 return true;
154 } 154 }
155 155
156 } // namespace 156 } // namespace
157 157
158 namespace extensions { 158 namespace extensions {
(...skipping 346 matching lines...) Expand 10 before | Expand all | Expand 10 after
505 if (!verified) 505 if (!verified)
506 result.reset(); 506 result.reset();
507 } 507 }
508 508
509 if (!callback_.is_null()) 509 if (!callback_.is_null())
510 callback_.Run(std::move(result)); 510 callback_.Run(std::move(result));
511 } 511 }
512 512
513 513
514 } // namespace extensions 514 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698