Change base::Value::ListStorage to std::vector<base::Value>

extensions/common/extension_l10n_util_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/extension_l10n_util.h"
 
 #include <memory>
 
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
@@ skipping 412 matching lines @@
 }
 
 TEST(ExtensionL10nUtil, LocalizeManifestWithNameDescriptionFileHandlerTitle) {
   base::DictionaryValue manifest;
   manifest.SetString(keys::kName, "__MSG_name__");
   manifest.SetString(keys::kDescription, "__MSG_description__");
   base::ListValue* handlers = new base::ListValue();
   manifest.Set(keys::kFileBrowserHandlers, handlers);
   base::DictionaryValue* handler = new base::DictionaryValue();
   handlers->Append(base::WrapUnique(handler));
+  // |handler| is invalidated at this point, so it needs to be reset.
+  handlers->GetDictionary(handlers->GetSize() - 1, &handler);

[Devlin, 2017/03/15 15:25:04]

We can just inline the creation of the new DictionaryValue, since we won't use
it before refetching.
handlers->Append(base::MakeUnique<base::DictionaryValue>());
base::DictionaryValue* handler = nullptr;
handlers->GetDictionary(...);

[jdoerrie, 2017/03/24 08:54:37]

Done.

   handler->SetString(keys::kPageActionDefaultTitle,
                      "__MSG_file_handler_title__");
 
   std::string error;
   std::unique_ptr<MessageBundle> messages(CreateManifestBundle());
 
   EXPECT_TRUE(
       extension_l10n_util::LocalizeManifest(*messages, &manifest, &error));
 
   std::string result;
@@ skipping 192 matching lines @@
   extension_l10n_util::GetAllFallbackLocales("en_US", "all", &fallback_locales);
   ASSERT_EQ(3U, fallback_locales.size());
 
   CHECK_EQ("en_US", fallback_locales[0]);
   CHECK_EQ("en", fallback_locales[1]);
   CHECK_EQ("all", fallback_locales[2]);
 }
 
 }  // namespace
 }  // namespace extensions