Change base::Value::ListStorage to std::vector<base::Value>

components/ntp_snippets/remote/remote_suggestions_fetcher.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/remote/remote_suggestions_fetcher.h"
 
 #include <cstdlib>
 #include <utility>
 
 #include "base/files/file_path.h"
@@ skipping 107 matching lines @@
 // Creates suggestions from dictionary values in |list| and adds them to
 // |suggestions|. Returns true on success, false if anything went wrong.
 // |remote_category_id| is only used if |content_suggestions_api| is true.
 bool AddSuggestionsFromListValue(bool content_suggestions_api,
                                  int remote_category_id,
                                  const base::ListValue& list,
                                  RemoteSuggestion::PtrVector* suggestions,
                                  const base::Time& fetch_time) {
   for (const auto& value : list) {
     const base::DictionaryValue* dict = nullptr;
-    if (!value->GetAsDictionary(&dict)) {
+    if (!value.GetAsDictionary(&dict)) {
       return false;
     }
 
     std::unique_ptr<RemoteSuggestion> suggestion;
     if (content_suggestions_api) {
       suggestion = RemoteSuggestion::CreateFromContentSuggestionsDictionary(
           *dict, remote_category_id, fetch_time);
     } else {
       suggestion =
           RemoteSuggestion::CreateFromChromeReaderDictionary(*dict, fetch_time);
@@ skipping 369 matching lines @@
     case FetchAPI::CHROME_CONTENT_SUGGESTIONS_API: {
       const base::ListValue* categories_value = nullptr;
       if (!top_dict->GetList("categories", &categories_value)) {
         return false;
       }
 
       for (const auto& v : *categories_value) {
         std::string utf8_title;
         int remote_category_id = -1;
         const base::DictionaryValue* category_value = nullptr;
-        if (!(v->GetAsDictionary(&category_value) &&
+        if (!(v.GetAsDictionary(&category_value) &&
               category_value->GetString("localizedTitle", &utf8_title) &&
               category_value->GetInteger("id", &remote_category_id) &&
               (remote_category_id > 0))) {
           return false;
         }
 
         RemoteSuggestion::PtrVector suggestions;
         const base::ListValue* suggestions_list = nullptr;
         // Absence of a list of suggestions is treated as an empty list, which
         // is permissible.
@@ skipping 22 matching lines @@
         categories->back().suggestions = std::move(suggestions);
       }
       return true;
     }
   }
   NOTREACHED();
   return false;
 }
 
 }  // namespace ntp_snippets