Change base::Value::ListStorage to std::vector<base::Value>

chrome/browser/ui/webui/browsing_history_handler.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/browsing_history_handler.h"
 
 #include <stddef.h>
 
 #include <set>
 #include <utility>
@@ skipping 346 matching lines @@
   options.duplicate_policy = history::QueryOptions::REMOVE_DUPLICATES_PER_DAY;
   browsing_history_service_->QueryHistory(search_text, options);
 }
 
 void BrowsingHistoryHandler::HandleRemoveVisits(const base::ListValue* args) {
   std::vector<std::unique_ptr<BrowsingHistoryService::HistoryEntry>>
       items_to_remove;
   items_to_remove.reserve(args->GetSize());
   for (base::ListValue::const_iterator it = args->begin();
        it != args->end(); ++it) {
-    base::DictionaryValue* deletion = NULL;
+    const base::DictionaryValue* deletion = NULL;
     base::string16 url;
-    base::ListValue* timestamps = NULL;
+    const base::ListValue* timestamps = NULL;
 
     // Each argument is a dictionary with properties "url" and "timestamps".
-    if (!((*it)->GetAsDictionary(&deletion) &&
-        deletion->GetString("url", &url) &&
-        deletion->GetList("timestamps", &timestamps))) {
+    if (!(it->GetAsDictionary(&deletion) && deletion->GetString("url", &url) &&
+          deletion->GetList("timestamps", &timestamps))) {
       NOTREACHED() << "Unable to extract arguments";
       return;
     }
     DCHECK(timestamps->GetSize() > 0);
     std::unique_ptr<BrowsingHistoryService::HistoryEntry> entry(
             new BrowsingHistoryService::HistoryEntry());
 
     entry->url = GURL(url);
 
     double timestamp;
     for (base::ListValue::const_iterator ts_iterator = timestamps->begin();
          ts_iterator != timestamps->end(); ++ts_iterator) {
-      if (!(*ts_iterator)->GetAsDouble(&timestamp)) {
+      if (!ts_iterator->GetAsDouble(&timestamp)) {
         NOTREACHED() << "Unable to extract visit timestamp.";
         continue;
       }
 
       base::Time visit_time = base::Time::FromJsTime(timestamp);
       entry->all_timestamps.insert(visit_time.ToInternalValue());
     }
 
     items_to_remove.push_back(std::move(entry));
   }
@@ skipping 151 matching lines @@
   web_ui()->CallJavascriptFunctionUnsafe("historyDeleted");
 }
 
 void BrowsingHistoryHandler::HasOtherFormsOfBrowsingHistory(
     bool has_other_forms,
     bool has_synced_results) {
   web_ui()->CallJavascriptFunctionUnsafe("showNotification",
                                          base::Value(has_synced_results),
                                          base::Value(has_other_forms));
 }