Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Side by Side Diff: chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Comment Updates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_so urce.h" 5 #include "chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_so urce.h"
6 6
7 #include "base/json/json_string_value_serializer.h" 7 #include "base/json/json_string_value_serializer.h"
8 #include "base/sys_info.h" 8 #include "base/sys_info.h"
9 #include "base/task_scheduler/post_task.h" 9 #include "base/task_scheduler/post_task.h"
10 #include "build/build_config.h" 10 #include "build/build_config.h"
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 service, service->signin(), chrome::GetChannel())); 161 service, service->signin(), chrome::GetChannel()));
162 162
163 // Remove identity section. 163 // Remove identity section.
164 base::ListValue* details = NULL; 164 base::ListValue* details = NULL;
165 sync_logs->GetList(syncer::sync_ui_util::kDetailsKey, &details); 165 sync_logs->GetList(syncer::sync_ui_util::kDetailsKey, &details);
166 if (!details) 166 if (!details)
167 return; 167 return;
168 for (base::ListValue::iterator it = details->begin(); 168 for (base::ListValue::iterator it = details->begin();
169 it != details->end(); ++it) { 169 it != details->end(); ++it) {
170 base::DictionaryValue* dict = NULL; 170 base::DictionaryValue* dict = NULL;
171 if ((*it)->GetAsDictionary(&dict)) { 171 if (it->GetAsDictionary(&dict)) {
172 std::string title; 172 std::string title;
173 dict->GetString("title", &title); 173 dict->GetString("title", &title);
174 if (title == syncer::sync_ui_util::kIdentityTitle) { 174 if (title == syncer::sync_ui_util::kIdentityTitle) {
175 details->Erase(it, NULL); 175 details->Erase(it, NULL);
176 break; 176 break;
177 } 177 }
178 } 178 }
179 } 179 }
180 180
181 // Add sync logs to logs. 181 // Add sync logs to logs.
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
262 void ChromeInternalLogSource::PopulateInstallerBrandCode( 262 void ChromeInternalLogSource::PopulateInstallerBrandCode(
263 SystemLogsResponse* response) { 263 SystemLogsResponse* response) {
264 std::string brand; 264 std::string brand;
265 google_brand::GetBrand(&brand); 265 google_brand::GetBrand(&brand);
266 (*response)[kInstallerBrandCode] = 266 (*response)[kInstallerBrandCode] =
267 brand.empty() ? "Unknown brand code" : brand; 267 brand.empty() ? "Unknown brand code" : brand;
268 } 268 }
269 #endif 269 #endif
270 270
271 } // namespace system_logs 271 } // namespace system_logs
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698