Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: content/public/android/java/res/menu/select_action_menu.xml

Issue 2740103006: Implement SmartText selection. (Closed)
Patch Set: Addressed some comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/res/menu/select_action_menu.xml
diff --git a/content/public/android/java/res/menu/select_action_menu.xml b/content/public/android/java/res/menu/select_action_menu.xml
index 30e3e836bd9e70b19111e4bd38f414f7f43e4be1..fef0bd76b82de6e0284cb5e8b6a65fbe107efb5e 100644
--- a/content/public/android/java/res/menu/select_action_menu.xml
+++ b/content/public/android/java/res/menu/select_action_menu.xml
@@ -9,11 +9,18 @@
<!--suppress AlwaysShowAction -->
<menu xmlns:android="http://schemas.android.com/apk/res/android">
<item
+ android:id="@+id/select_action_menu_context_dep"
+ android:title="@android:string/unknownName"
Ted C 2017/03/20 20:35:50 should this be "@null"?
Tima Vaisburd 2017/03/21 02:07:01 Done.
+ android:showAsAction="always|withText"
+ android:orderInCategory="1"
Ted C 2017/03/20 20:35:49 do you need these orderInCategory? It should use
Tima Vaisburd 2017/03/21 02:07:01 I thought I did, but eventually I found another wa
+ />
+ <item
android:id="@+id/select_action_menu_cut"
android:icon="?android:attr/actionModeCutDrawable"
android:title="@android:string/cut"
android:showAsAction="always|withText"
android:alphabeticShortcut="x"
+ android:orderInCategory="2"
/>
<item
android:id="@+id/select_action_menu_copy"
@@ -21,6 +28,7 @@
android:title="@android:string/copy"
android:showAsAction="always|withText"
android:alphabeticShortcut="c"
+ android:orderInCategory="3"
/>
<item
android:id="@+id/select_action_menu_paste"
@@ -28,12 +36,14 @@
android:title="@android:string/paste"
android:showAsAction="always|withText"
android:alphabeticShortcut="v"
+ android:orderInCategory="4"
/>
<item
android:id="@+id/select_action_menu_share"
android:title="@string/actionbar_share"
android:showAsAction="always|withText"
style="@style/SelectActionMenuShare"
+ android:orderInCategory="5"
/>
<item
android:id="@+id/select_action_menu_select_all"
@@ -41,14 +51,18 @@
android:title="@android:string/selectAll"
android:showAsAction="always|withText"
android:alphabeticShortcut="a"
+ android:orderInCategory="6"
/>
<group
- android:id="@+id/select_action_menu_text_processing_menus">
+ android:id="@+id/select_action_menu_text_processing_menus"
+ android:menuCategory="system"
Ted C 2017/03/20 20:35:49 Why is this needed?
Tima Vaisburd 2017/03/21 02:07:02 Forgot to remove. Right now both menuCategory and
+ android:orderInCategory="7">
</group>
<item
android:id="@+id/select_action_menu_web_search"
android:title="@string/actionbar_web_search"
android:showAsAction="always|withText"
style="@style/SelectActionMenuWebSearch"
+ android:orderInCategory="8"
/>
</menu>

Powered by Google App Engine
This is Rietveld 408576698