content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 2740103006: Implement SmartText selection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 2740103006: Implement SmartText selection. (Closed)

Patch Set: Do not invalidate the menu and always recreate it; use Android resource id for Assist Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/java/res/menu/select_action_menu.xml ('K') | « content/public/android/java/res/menu/select_action_menu.xml ('k') | content/public/android/java/src/org/chromium/content/browser/ContextSelectionClient.java » ('j') | content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index b8394ca23a122b07ceb199e6d97c1ffcb87213a3..d08a6d2c1e5a49f12e26b75c3cfcf676ffa1aea2 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -1645,7 +1645,7 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa

}

private void showSelectActionMode() {

- if (!mSelectionPopupController.showActionMode()) clearSelection();

+ mSelectionPopupController.showActionModeOrClearOnFailure();

}

public void clearSelection() {