Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Side by Side Diff: content/public/android/java/res/menu/select_action_menu.xml

Issue 2740103006: Implement SmartText selection. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 2
3 <!-- Copyright 2013 The Chromium Authors. All rights reserved. 3 <!-- Copyright 2013 The Chromium Authors. All rights reserved.
4 4
5 Use of this source code is governed by a BSD-style license that can be 5 Use of this source code is governed by a BSD-style license that can be
6 found in the LICENSE file. 6 found in the LICENSE file.
7 --> 7 -->
8 8
9 <!--suppress AlwaysShowAction --> 9 <!--suppress AlwaysShowAction -->
10 <menu xmlns:android="http://schemas.android.com/apk/res/android"> 10 <menu xmlns:android="http://schemas.android.com/apk/res/android">
11 <item 11 <item
12 android:id="@+id/select_action_menu_context_dep"
13 android:title="@android:string/yes"
boliu 2017/03/11 00:37:52 "yes"?
Tima Vaisburd 2017/03/20 05:06:04 string/unknownName to the rescue. The android:titl
14 android:showAsAction="always|withText"
15 android:menuCategory="system"
16 android:orderInCategory="1"
17 />
18 <item
12 android:id="@+id/select_action_menu_cut" 19 android:id="@+id/select_action_menu_cut"
13 android:icon="?android:attr/actionModeCutDrawable" 20 android:icon="?android:attr/actionModeCutDrawable"
14 android:title="@android:string/cut" 21 android:title="@android:string/cut"
15 android:showAsAction="always|withText" 22 android:showAsAction="always|withText"
16 android:alphabeticShortcut="x" 23 android:alphabeticShortcut="x"
24 android:menuCategory="system"
boliu 2017/03/11 00:37:52 what does do exactly?
25 android:orderInCategory="2"
boliu 2017/03/11 00:37:52 aren't these ordered before? why is it important e
Tima Vaisburd 2017/03/20 05:06:04 The difference is that now I try to add a menu ite
17 /> 26 />
18 <item 27 <item
19 android:id="@+id/select_action_menu_copy" 28 android:id="@+id/select_action_menu_copy"
20 android:icon="?android:attr/actionModeCopyDrawable" 29 android:icon="?android:attr/actionModeCopyDrawable"
21 android:title="@android:string/copy" 30 android:title="@android:string/copy"
22 android:showAsAction="always|withText" 31 android:showAsAction="always|withText"
23 android:alphabeticShortcut="c" 32 android:alphabeticShortcut="c"
33 android:menuCategory="system"
34 android:orderInCategory="3"
24 /> 35 />
25 <item 36 <item
26 android:id="@+id/select_action_menu_paste" 37 android:id="@+id/select_action_menu_paste"
27 android:icon="?android:attr/actionModePasteDrawable" 38 android:icon="?android:attr/actionModePasteDrawable"
28 android:title="@android:string/paste" 39 android:title="@android:string/paste"
29 android:showAsAction="always|withText" 40 android:showAsAction="always|withText"
30 android:alphabeticShortcut="v" 41 android:alphabeticShortcut="v"
42 android:menuCategory="system"
43 android:orderInCategory="4"
31 /> 44 />
32 <item 45 <item
33 android:id="@+id/select_action_menu_share" 46 android:id="@+id/select_action_menu_share"
34 android:title="@string/actionbar_share" 47 android:title="@string/actionbar_share"
35 android:showAsAction="always|withText" 48 android:showAsAction="always|withText"
36 style="@style/SelectActionMenuShare" 49 style="@style/SelectActionMenuShare"
50 android:menuCategory="system"
51 android:orderInCategory="5"
37 /> 52 />
38 <item 53 <item
39 android:id="@+id/select_action_menu_select_all" 54 android:id="@+id/select_action_menu_select_all"
40 android:icon="?android:attr/actionModeSelectAllDrawable" 55 android:icon="?android:attr/actionModeSelectAllDrawable"
41 android:title="@android:string/selectAll" 56 android:title="@android:string/selectAll"
42 android:showAsAction="always|withText" 57 android:showAsAction="always|withText"
43 android:alphabeticShortcut="a" 58 android:alphabeticShortcut="a"
59 android:menuCategory="system"
60 android:orderInCategory="6"
44 /> 61 />
45 <group 62 <group
46 android:id="@+id/select_action_menu_text_processing_menus"> 63 android:id="@+id/select_action_menu_text_processing_menus"
64 android:menuCategory="system"
65 android:orderInCategory="7">
47 </group> 66 </group>
48 <item 67 <item
49 android:id="@+id/select_action_menu_web_search" 68 android:id="@+id/select_action_menu_web_search"
50 android:title="@string/actionbar_web_search" 69 android:title="@string/actionbar_web_search"
51 android:showAsAction="always|withText" 70 android:showAsAction="always|withText"
52 style="@style/SelectActionMenuWebSearch" 71 style="@style/SelectActionMenuWebSearch"
72 android:menuCategory="system"
73 android:orderInCategory="8"
53 /> 74 />
54 </menu> 75 </menu>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698