Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/flatbuffers/BUILD.gn

Issue 2740103002: Update FlatBuffers to version 1.5.0. (Closed)
Patch Set: Fix build; add define. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/flatbuffers/BUILD.gn
diff --git a/third_party/flatbuffers/BUILD.gn b/third_party/flatbuffers/BUILD.gn
index a6dc8f42ec8533f61ff45f9163bc5841d0e44d26..edc0d4c0c5dfbc0ea810ad771bf7bbefa5fc24aa 100644
--- a/third_party/flatbuffers/BUILD.gn
+++ b/third_party/flatbuffers/BUILD.gn
@@ -21,7 +21,13 @@ source_set("flatbuffers") {
}
source_set("compiler_files") {
+ include_dirs = [ "src/grpc" ]
sources = [
+ "src/grpc/src/compiler/cpp_generator.cc",
+ "src/grpc/src/compiler/cpp_generator.h",
+ "src/grpc/src/compiler/go_generator.cc",
+ "src/grpc/src/compiler/go_generator.h",
+ "src/grpc/src/compiler/schema_interface.h",
"src/include/flatbuffers/code_generators.h",
"src/include/flatbuffers/idl.h",
"src/include/flatbuffers/util.h",
@@ -29,6 +35,7 @@ source_set("compiler_files") {
"src/src/idl_gen_fbs.cpp",
"src/src/idl_gen_general.cpp",
"src/src/idl_gen_go.cpp",
+ "src/src/idl_gen_grpc.cpp",
"src/src/idl_gen_js.cpp",
"src/src/idl_gen_php.cpp",
"src/src/idl_gen_python.cpp",
@@ -78,6 +85,12 @@ test("flatbuffers_unittest") {
# This is the actual test.
"src/tests/test.cpp",
+
+ # FIXME: Add the following tests:
+ # - grpc/tests/grpctest.cpp
pkalinnikov 2017/03/09 13:03:17 I suppose this test should be added similarly to "
engedy 2017/03/09 14:53:14 Right. Note, however, that each of these exports a
pkalinnikov 2017/03/09 17:36:58 Filed crbug.com/700039 for this and the one below.
+ # - tests/fuzzer/flatbuffers_verifier_fuzzer.cc
+ # - tests/fuzzer/flatbuffers_parser_fuzzer.cc
pkalinnikov 2017/03/09 13:03:17 These 2 fuzzer tests are not included into CMakeLi
engedy 2017/03/09 14:53:14 I believe this is exercised by ClusterFuzz outside
pkalinnikov 2017/03/09 17:36:58 Done.
+ # - tests/monster_test.grpc.fb.cc
pkalinnikov 2017/03/09 13:03:17 This one is probably not a test. Will delete it.
pkalinnikov 2017/03/09 17:36:58 Done.
]
deps = [
":compiler_files",
@@ -87,4 +100,5 @@ test("flatbuffers_unittest") {
data = [
"src/tests/",
]
+ defines = [ "FLATBUFFERS_TRACK_VERIFIER_BUFFER_SIZE" ]
}

Powered by Google App Engine
This is Rietveld 408576698