Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp

Issue 2740083002: Add support for shaper-driven line breaking to HarfBuzzShaper (Closed)
Patch Set: Try to fix test failures Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp b/third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp
index 504df23d42d2a7f45f845ac2badafe006b6531d7..8a587c23fa05462ffbab85f04e9cb2deb1f923a7 100644
--- a/third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp
+++ b/third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp
@@ -417,6 +417,30 @@ void ShapeResult::insertRun(std::unique_ptr<ShapeResult::RunInfo> runToInsert,
m_runs.push_back(std::move(run));
}
+void ShapeResult::copyRange(unsigned startOffset,
+ unsigned endOffset,
+ ShapeResult* target) const {
+ unsigned index = target->m_numCharacters;
+ for (const auto& run : m_runs) {
+ unsigned runStart = (*run).m_startIndex;
+ unsigned runEnd = runStart + (*run).m_numCharacters;
+
+ if (startOffset < runEnd && endOffset > runStart) {
+ unsigned start = startOffset > runStart ? startOffset - runStart : 0;
+ unsigned end = std::min(endOffset - runStart, runEnd);
+ DCHECK(end > start);
+
+ ShapeResult::RunInfo* subRun = (*run).createSubRun(start, end);
+ subRun->m_startIndex = index;
+ target->m_runs.push_back(WTF::wrapUnique(subRun));
+ target->m_width += subRun->m_width;
+ index += subRun->m_numCharacters;
+ }
+ }
+
+ target->m_numCharacters = index;
+}
+
PassRefPtr<ShapeResult> ShapeResult::createForTabulationCharacters(
const Font* font,
const TextRun& textRun,

Powered by Google App Engine
This is Rietveld 408576698