Fix tab restore for view-source Chrome extension pages.

content/public/browser/content_browser_client.h

Index: content/public/browser/content_browser_client.h
diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h
index 4dd626e7914dd439ed863765d9a955c1fc54f611..e94f689164a89e66bd3f55f6aae3c61f2db3eafe 100644
--- a/content/public/browser/content_browser_client.h
+++ b/content/public/browser/content_browser_client.h
@@ -216,11 +216,14 @@ class CONTENT_EXPORT ContentBrowserClient {
   // Returns a list additional WebUI schemes, if any.  These additional schemes
   // act as aliases to the chrome: scheme.  The additional schemes may or may
   // not serve specific WebUI pages depending on the particular URLDataSource
-  // and its override of URLDataSource::ShouldServiceRequest. For all schemes
-  // returned here, view-source is allowed.
+  // and its override of URLDataSource::ShouldServiceRequest.
   virtual void GetAdditionalWebUISchemes(
       std::vector<std::string>* additional_schemes) {}
 
+  // Returns a list of additional schemes allowed for view-source.
+  virtual void GetAdditionalViewSourceSchemes(
+      std::vector<std::string>* additional_schemes) {}

[Charlie Reis, 2017/03/15 15:03:31]

I wonder if there's a risk that this breaks view-source in other content
embedders, like Opera?  They won't know to implement this right away, and
suddenly their WebUI schemes won't allow view-source.

It'd be a bit inconsistent with other methods in here, but we could make the
default implementation return GetAdditionalWebUISchemes (in the .cc file, plus
documented here) to avoid the issue.

[alexmos, 2017/03/16 20:07:30]

Good idea.  Done.

+
   // Called when WebUI objects are created to get aggregate usage data (i.e. is
   // chrome://downloads used more than chrome://bookmarks?). Only internal (e.g.
   // chrome://) URLs are logged. Returns whether the URL was actually logged.