Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2739953002: dart2js: num.compareTo is pure, and a.compareTo(a) is zero (Closed)

Created:
3 years, 9 months ago by sra1
Modified:
3 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: num.compareTo is pure, and a.compareTo(a) is usually zero BUG= R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/6d9fc0cc626b0bb64ee345961d2a044022ff4d00

Patch Set 1 #

Patch Set 2 : rebase and format #

Patch Set 3 : Fix merge error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -3 lines) Patch
M pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart View 1 2 16 chunks +46 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (7 generated)
sra1
3 years, 8 months ago (2017-04-03 18:32:30 UTC) #7
Emily Fortuna
lgtm
3 years, 8 months ago (2017-04-03 20:23:22 UTC) #8
sra1
3 years, 8 months ago (2017-04-04 01:03:48 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:120001) manually as
6d9fc0cc626b0bb64ee345961d2a044022ff4d00 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698