Cleanup: Remove SearchTabHelperDelegate

Cleanup: Remove SearchTabHelperDelegate

Its one remaining member, GetOmniboxView, can be replaced easily by
telling the SearchTabHelper when its tab gets attached to a new window
(i.e. Browser::TabInsertedAt), at which point it can grab the
OmniboxView* itself. This also correctly handles the case where a tab
is dragged between windows.

BUG=627747

[Marc Treib, 2017-03-09 16:47:58]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 16:48:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 17:39:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 17:39:50]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2017-03-10 08:48:43]

Description was changed from

==========
Cleanup: Remove SearchTabHelperDelegate

Its one remaining member, GetOmniboxView, can be replaced easily by
explicitly passing the OmniboxView* to SearchTabHelper.

BUG=627747
==========

to

==========
Cleanup: Remove SearchTabHelperDelegate

Its one remaining member, GetOmniboxView, can be replaced easily by
explicitly passing the OmniboxView* to SearchTabHelper from
Browser::TabInsertedAt. If a tab gets dragged between windows, this
gets called at all the right times, so SearchTabHelper always has a
valid OmniboxView*.

BUG=627747
==========

[Marc Treib, 2017-03-10 08:49:07]

treib@chromium.org changed reviewers:
+ pkasting@chromium.org

[Marc Treib, 2017-03-10 08:49:08]

This turned out to Just Work :)  PTAL!

[Peter Kasting, 2017-03-10 10:20:00]

LGTM

https://codereview.chromium.org/2739943005/diff/1/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

https://codereview.chromium.org/2739943005/diff/1/chrome/browser/ui/browser.c...
chrome/browser/ui/browser.cc:970: SearchTabHelper::FromWebContents(contents);
Nit: Or could inline into next line

https://codereview.chromium.org/2739943005/diff/1/chrome/browser/ui/search/se...
File chrome/browser/ui/search/search_tab_helper.h (right):

https://codereview.chromium.org/2739943005/diff/1/chrome/browser/ui/search/se...
chrome/browser/ui/search/search_tab_helper.h:85: void
SetOmniboxView(OmniboxView* omnibox_view);
Nit: The comment suggests that this would be named something like
OnTabAttachedToWindow().  It's slightly odd for the comments on this function to
document something seemingly-unrelated about what the caller does with it.

I wonder if this shouldn't be OnTabInserted() (since that's what the browser
function calling it is).  I also wonder if it should pull the omnibox view from
the browser (rather than having it provided), but that's mostly for API
cleanliness/parallelism with the above methods.

[Marc Treib, 2017-03-10 11:30:03]

https://codereview.chromium.org/2739943005/diff/1/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

https://codereview.chromium.org/2739943005/diff/1/chrome/browser/ui/browser.c...
chrome/browser/ui/browser.cc:970: SearchTabHelper::FromWebContents(contents);
On 2017/03/10 10:19:57, Peter Kasting wrote:
> Nit: Or could inline into next line

Sure, done.
(I was copying the style from SessionTabHelper above; I've inlined that too.)

https://codereview.chromium.org/2739943005/diff/1/chrome/browser/ui/search/se...
File chrome/browser/ui/search/search_tab_helper.h (right):

https://codereview.chromium.org/2739943005/diff/1/chrome/browser/ui/search/se...
chrome/browser/ui/search/search_tab_helper.h:85: void
SetOmniboxView(OmniboxView* omnibox_view);
On 2017/03/10 10:19:57, Peter Kasting wrote:
> Nit: The comment suggests that this would be named something like
> OnTabAttachedToWindow().  It's slightly odd for the comments on this function
to
> document something seemingly-unrelated about what the caller does with it.
> 
> I wonder if this shouldn't be OnTabInserted() (since that's what the browser
> function calling it is).  I also wonder if it should pull the omnibox view
from
> the browser (rather than having it provided), but that's mostly for API
> cleanliness/parallelism with the above methods.

Indeed, that seems much more consistent with the other methods. Thanks!

I've made it "OnTabAttachedToWindow(BrowerWindow*)"; IMO "OnTabInserted" lacks
some context here (inserted into what?).

[Marc Treib, 2017-03-10 11:31:42]

Description was changed from

==========
Cleanup: Remove SearchTabHelperDelegate

Its one remaining member, GetOmniboxView, can be replaced easily by
explicitly passing the OmniboxView* to SearchTabHelper from
Browser::TabInsertedAt. If a tab gets dragged between windows, this
gets called at all the right times, so SearchTabHelper always has a
valid OmniboxView*.

BUG=627747
==========

to

==========
Cleanup: Remove SearchTabHelperDelegate

Its one remaining member, GetOmniboxView, could be replaced easily by
telling the SearchTabHelper when its tab gets attached to a new window
(i.e. Browser::TabInsertedAt), at which point it can grab the OmniboxView*
itself. This also correctly handles the case where a tab
is dragged between windows.

BUG=627747
==========

[Marc Treib, 2017-03-10 11:32:09]

Description was changed from

==========
Cleanup: Remove SearchTabHelperDelegate

Its one remaining member, GetOmniboxView, could be replaced easily by
telling the SearchTabHelper when its tab gets attached to a new window
(i.e. Browser::TabInsertedAt), at which point it can grab the OmniboxView*
itself. This also correctly handles the case where a tab
is dragged between windows.

BUG=627747
==========

to

==========
Cleanup: Remove SearchTabHelperDelegate

Its one remaining member, GetOmniboxView, can be replaced easily by
telling the SearchTabHelper when its tab gets attached to a new window
(i.e. Browser::TabInsertedAt), at which point it can grab the
OmniboxView* itself. This also correctly handles the case where a tab
is dragged between windows.

BUG=627747
==========

[Marc Treib, 2017-03-10 11:32:15]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 11:32:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 12:19:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 12:19:35]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2017-03-10 12:26:32]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2017-03-10 12:26:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2739943005/#ps20001
(title: "review")

[commit-bot: I haz the power, 2017-03-10 12:26:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 12:31:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489148792732550,
"parent_rev": "3e1c8c2a1cde9d01f965ce41f71e7ca959740fae", "commit_rev":
"9b207c01a4d7df3381eb1fefc6d62be7847e1365"}

[commit-bot: I haz the power, 2017-03-10 12:36:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 12:36:04]

Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.