Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1080)

Unified Diff: Source/core/loader/ThreadableLoader.h

Issue 273993002: Allow XHR timeout attribute to be overridden after send(), per spec (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed accuracy issues with removed Timer methods Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/loader/ThreadableLoader.h
diff --git a/Source/core/loader/ThreadableLoader.h b/Source/core/loader/ThreadableLoader.h
index f562551f623e1363ec8e76599091826bc9b8553d..530bf8aac859648cbe8bdd291ca70eaf2be6b9ab 100644
--- a/Source/core/loader/ThreadableLoader.h
+++ b/Source/core/loader/ThreadableLoader.h
@@ -84,6 +84,11 @@ namespace WebCore {
static void loadResourceSynchronously(ExecutionContext&, const ResourceRequest&, ThreadableLoaderClient&, const ThreadableLoaderOptions&);
static PassRefPtr<ThreadableLoader> create(ExecutionContext&, ThreadableLoaderClient*, const ResourceRequest&, const ThreadableLoaderOptions&);
+ // A ThreadableLoader may have a timeout specified. It is possible, in some cases, for
+ // the timeout to be overridden after the request is sent (for example, XMLHttpRequests
+ // may override their timeout setting after sending).
tyoshino (SeeGerritForStatus) 2014/05/12 09:21:17 please explain that the timeout will be updated to
+ virtual void overrideTimeout(unsigned long timeoutMilliseconds) = 0;
+
virtual void cancel() = 0;
virtual ~ThreadableLoader() { }

Powered by Google App Engine
This is Rietveld 408576698