Source/core/loader/DocumentThreadableLoader.h - Issue 273993002: Allow XHR timeout attribute to be overridden after send(), per spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/DocumentThreadableLoader.h

Issue 273993002: Allow XHR timeout attribute to be overridden after send(), per spec (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed accuracy issues with removed Timer methods Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/xmlhttprequest/workers/resources/xmlhttprequest-timeout-override-worker.js ('K') | « LayoutTests/http/tests/xmlhttprequest/workers/xmlhttprequest-timeout-override-expected.txt ('k') | Source/core/loader/DocumentThreadableLoader.cpp » ('j') | Source/core/loader/DocumentThreadableLoader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/loader/DocumentThreadableLoader.h

diff --git a/Source/core/loader/DocumentThreadableLoader.h b/Source/core/loader/DocumentThreadableLoader.h

index 216840726952c946f98d07a7b05fe4ac3ada0ac7..5a8d54de23eee3c06ca5db89a581b1cb03b23571 100644

--- a/Source/core/loader/DocumentThreadableLoader.h

+++ b/Source/core/loader/DocumentThreadableLoader.h

@@ -58,6 +58,8 @@ class DocumentThreadableLoader FINAL : public ThreadableLoader, private Resource

static PassRefPtr<DocumentThreadableLoader> create(Document&, ThreadableLoaderClient*, const ResourceRequest&, const ThreadableLoaderOptions&);

virtual ~DocumentThreadableLoader();

+ virtual void overrideTimeout(unsigned long timeout) OVERRIDE;

virtual void cancel() OVERRIDE;

void setDefersLoading(bool);

@@ -101,6 +103,7 @@ class DocumentThreadableLoader FINAL : public ThreadableLoader, private Resource

OwnPtr<ResourceRequest> m_actualRequest; // non-null during Access Control preflight checks

HTTPHeaderMap m_simpleRequestHeaders; // stores simple request headers in case of a cross-origin redirect.

Timer<DocumentThreadableLoader> m_timeoutTimer;

+ double m_requestStarted;

tyoshino (SeeGerritForStatus) 2014/05/12 09:21:17 please add a comment to explain on what kind of ev

};

} // namespace WebCore