Source/core/loader/ThreadableLoader.h - Issue 273993002: Allow XHR timeout attribute to be overridden after send(), per spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/ThreadableLoader.h

Issue 273993002: Allow XHR timeout attribute to be overridden after send(), per spec (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Avoid potential race-condition between load and timeout Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/loader/DocumentThreadableLoader.cpp ('K') | « Source/core/loader/DocumentThreadableLoader.cpp ('k') | Source/core/loader/WorkerThreadableLoader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/loader/ThreadableLoader.h

diff --git a/Source/core/loader/ThreadableLoader.h b/Source/core/loader/ThreadableLoader.h

index f562551f623e1363ec8e76599091826bc9b8553d..2ed71dc32b8a8da2de7788cf7cbc4269783fdd53 100644

--- a/Source/core/loader/ThreadableLoader.h

+++ b/Source/core/loader/ThreadableLoader.h

@@ -84,6 +84,13 @@ namespace WebCore {

static void loadResourceSynchronously(ExecutionContext&, const ResourceRequest&, ThreadableLoaderClient&, const ThreadableLoaderOptions&);

static PassRefPtr<ThreadableLoader> create(ExecutionContext&, ThreadableLoaderClient*, const ResourceRequest&, const ThreadableLoaderOptions&);

+ // A ThreadableLoader may have a timeout specified. It is possible, in some cases, for

+ // the timeout to be overridden after the request is sent (for example, XMLHttpRequests

+ // may override their timeout setting after sending).

+ //

+ // Set a new timeout relative to the time the request started, in milliseconds.

+ virtual void overrideTimeout(unsigned long timeoutMilliseconds) = 0;

virtual void cancel() = 0;

virtual ~ThreadableLoader() { }