Issue 2739913002: Revert "Turn the DOWN_CAST_COMPOSITE strong mode error into a hint, which will"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2739913002: Revert "Turn the DOWN_CAST_COMPOSITE strong mode error into a hint, which will" (Closed)

Created:
3 years, 9 months ago by kasperl

Modified:
3 years, 9 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Revert "Turn the DOWN_CAST_COMPOSITE strong mode error into a hint, which will" This reverts commit fa2a3a1afa1a1e0eb748783472b25214d53aceec. R=vsm@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/b1ea3e01bcf7d14ed7e318edc3585b5af26b7b07

Patch Set 1 #

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	pkg/analyzer/lib/src/error/codes.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kasperl

Committed patchset #1 (id:1) manually as b1ea3e01bcf7d14ed7e318edc3585b5af26b7b07 (presubmit successful).

3 years, 9 months ago (2017-03-08 22:29:13 UTC) #3

vsm

3 years, 9 months ago (2017-03-08 22:33:25 UTC) #5

Message was sent while issue was closed.

On 2017/03/08 22:29:30, kasperl wrote:
> TBR'ed.

lgtm

Looks like some tests need to be updated?

I think the first two tests here:

https://github.com/dart-lang/sdk/tree/master/pkg/analyzer/test/src/task/strong

will need:

s/warning:DOWN_CAST_COMPOSITE/info:DOWN_CAST_COMPOSITE/g

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages