pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart - Issue 2739863003: Add option to suppress type-check whitelisting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

Issue 2739863003: Add option to suppress type-check whitelisting (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart ('k') | pkg/dev_compiler/tool/input_sdk/private/regexp_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

diff --git a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

index f89ca0c81283beb9d44df5a0df4ed9111de76e61..f7fa49105fab10aad80afb94d475187a898db39b 100644

--- a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

+++ b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

@@ -498,7 +498,7 @@ bool strongInstanceOf(obj, type, ignoreFromWhiteList) => JS(

if (result || actual == $jsobject ||

actual == $int && type == $double) return true;

if (result === false) return false;

- if ($ignoreFromWhiteList == void 0) return result;

+ if (!$_ignoreWhitelistedErrors || ($ignoreFromWhiteList == void 0)) return result;

if ($_ignoreTypeFailure(actual, $type)) return true;

return result;

})()''');