Add option to suppress type-check whitelisting

pkg/dev_compiler/test/browser/language_tests.js

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
       function(dart_sdk, async_helper, expect, unittest, is, require) {
   'use strict';
 
   async_helper = async_helper.async_helper;
   let minitest = expect.minitest;
   let mochaOnError = window.onerror;
   dart_sdk.dart.trapRuntimeErrors(false);
+  dart_sdk.dart.ignoreWhitelistedErrors(false);
   dart_sdk._isolate_helper.startRootIsolate(function() {}, []);
   // Make it easier to debug test failures and required for formatter test that
   // assumes custom formatters are enabled.
   dart_sdk._debugger.registerDevtoolsFormatter();
 
   let html_config = unittest.html_config;
   // Test attributes are a list of strings, or a string for a single
   // attribute. Valid attributes are:
   //
   //   'pass' - test passes (default)
   //   'skip' - don't run the test
   //   'fail' - test fails
   //   'timeout' - test times out
   //   'slow' - use 5s timeout instead of default 2s.
   //   'helper'  - not a test, used by other tests.
   //   'unittest' - run separately as a unittest test.
+  //   'whitelist' - run with whitelisted type errors allowed
   //
   // Common combinations:
   const pass = 'pass';
   const fail = 'fail';
   const skip_timeout = ['skip', 'timeout'];
 
   // Browsers
   const firefox_fail = is.firefox() ? fail : pass;
   const chrome_fail = is.chrome() ? fail : pass;
 
   // These are typically tests with asynchronous exceptions that our
   // test framework doesn't always catch.
   const flaky = 'skip';
+  const whitelist = 'whitelist';
 
   // Tests marked with this are still using the deprecated unittest package
   // because they rely on its support for futures and asynchronous tests, which
   // expect and minitest do not handle.
   // TODO(rnystrom): Move all of these away from using the async test API so
   // they can stop using unittest.
   const async_unittest = ['unittest', 'skip', 'fail'];
 
   // The number of expected unittest errors should be zero but unfortunately
   // there are a lot of broken html unittests.
@@ skipping 19 matching lines @@
 
       // TODO(vsm): Re-enable (https://github.com/dart-lang/sdk/issues/28319)
       'async_star_test_none_multi': async_unittest,
       'async_star_test_01_multi': async_unittest,
       'async_star_test_02_multi': async_unittest,
       'async_star_test_03_multi': async_unittest,
       'async_star_test_04_multi': async_unittest,
       'async_star_test_05_multi': async_unittest,
 
       'async_switch_test': fail,
+      'async_test': whitelist,
+      'async_this_bound_test': whitelist,
       'asyncstar_throw_in_catch_test': ['skip', 'fail'],
       'await_future_test': skip_timeout,
       'bit_operations_test_none_multi': fail,  // DDC/dart2js canonicalize bitop results to unsigned
       'branch_canonicalization_test': fail,  // JS bit operations truncate to 32 bits.
       'call_closurization_test': fail, // Functions do not expose a "call" method.
       'call_through_null_getter_test': fail, // null errors are not converted to NoSuchMethodErrors.
       'call_with_no_such_method_test': fail, // Function.apply not really implemented.
       'canonical_const2_test': fail,
       'canonical_const_test': fail,
       'cast_test_01_multi': fail,
@@ skipping 60 matching lines @@
       'function_subtype_bound_closure1_test': fail,
       'function_subtype_bound_closure2_test': fail,
       'function_subtype_bound_closure3_test': fail,
       'function_subtype_bound_closure4_test': fail,
       'function_subtype_bound_closure5_test': fail,
       'function_subtype_bound_closure5a_test': fail,
       'function_subtype_bound_closure6_test': fail,
       'function_subtype_call0_test': fail, // Strong mode "is" rejects some type tests.
       'function_subtype_call1_test': fail,
       'function_subtype_call2_test': fail,
-      'function_subtype_cast0_test': fail,
-      'function_subtype_cast1_test': fail,
-      'function_subtype_cast2_test': fail,
-      'function_subtype_cast3_test': fail,
       'function_subtype_factory0_test': fail,
       'function_subtype_inline0_test': fail,
       'function_subtype_local0_test': fail,
       'function_subtype_local1_test': fail,
       'function_subtype_local2_test': fail,
       'function_subtype_local3_test': fail,
       'function_subtype_local4_test': fail,
       'function_subtype_local5_test': fail,
       'function_subtype_named1_test': fail,
       'function_subtype_named2_test': fail,
@@ skipping 26 matching lines @@
       'instanceof4_test_none_multi': fail,
       'instanceof_optimized_test': fail,
       'integer_division_by_zero_test': fail,
       'issue_22780_test_01_multi': fail,
       'lazy_static3_test': fail,
       'least_upper_bound_expansive_test_none_multi': fail,
       'left_shift_test': fail,
       'list_is_test': fail,
       'list_literal3_test': fail,
       'many_generic_instanceof_test': fail,
+      'many_named_arguments_test': whitelist,
       'map_literal10_test': fail,
       'map_literal7_test': fail,
       'memory_swap_test': skip_timeout,
       'method_invocation_test': fail,
       'mint_arithmetic_test': fail,
       'mixin_forwarding_constructor3_test': fail,
       'mixin_implements_test': fail,
       'mixin_issue10216_2_test': fail,
       'mixin_mixin2_test': fail,
       'mixin_mixin3_test': fail,
       'mixin_mixin4_test': fail,
       'mixin_mixin5_test': fail,
       'mixin_mixin6_test': fail,
       'mixin_mixin7_test': fail,
       'mixin_mixin_bound2_test': fail,
       'mixin_mixin_bound_test': fail,
       'mixin_mixin_test': fail,
       'mixin_regress_13688_test': fail,
       'modulo_test': fail,
       'named_parameter_clash_test': fail,
       'named_parameters_passing_falsy_test': is.firefox('<=50') ? fail : pass,
       'nan_identical_test': fail,
       'nested_switch_label_test': fail,
       'number_identifier_test_05_multi': fail,
       'number_identity2_test': fail,
       'numbers_test': fail,
       'redirecting_factory_reflection_test': fail,
+      'reg_exp_test': whitelist,
       'regress_16640_test': fail,
       'regress_18535_test': fail,
       'regress_22666_test': fail,
       'regress_22777_test': flaky,
       'setter_no_getter_test_01_multi': fail,
       'stack_overflow_stacktrace_test': fail,
       'stack_overflow_test': fail,
       'stacktrace_rethrow_error_test_none_multi': fail,
       'stacktrace_rethrow_error_test_withtraceparameter_multi': fail,
       'stacktrace_test': chrome_fail,
@@ skipping 57 matching lines @@
       'hash_set_test_01_multi': fail,
       'hidden_library2_test_01_multi': fail,
       'int_modulo_arith_test_bignum_multi': fail,
       'int_modulo_arith_test_modPow_multi': fail,
       'int_modulo_arith_test_none_multi': fail,
       'int_parse_radix_test_01_multi': fail, // JS implementations disagree on U+0085 being whitespace.
       'int_parse_radix_test_02_multi': ['fail', 'timeout', 'skip'], // No bigints.
       'int_parse_radix_test_none_multi': ['slow'],
       'integer_to_radix_string_test': fail,
       'integer_to_string_test_01_multi': fail,
-      'iterable_generate_test': fail,
+      'iterable_empty_test': whitelist,
+      'iterable_join_test': whitelist,
       'iterable_return_type_test_02_multi': fail,
       'json_map_test': fail,
       'list_fill_range_test': fail,
+      'list_insert_all_test': whitelist,
       'list_replace_range_test': fail,
       'list_set_all_test': fail,
       'list_to_string2_test': fail,
       'main_test': fail,
       'map_keys2_test': fail,
       'map_to_string_test': fail,
       'map_from_iterable_test': is.firefox('<=50') ? fail : pass,
       'nan_infinity_test_01_multi': fail,
       'null_nosuchmethod_test': fail,
       'null_test': fail,
       'num_sign_test': fail,
+      'reg_exp_all_matches_test': whitelist,
+      'reg_exp_start_end_test': whitelist,
       'regress_r21715_test': fail,
       'throw_half_surrogate_pair_test_02_multi': fail,
+      'sort_test': whitelist,
       'splay_tree_from_iterable_test': is.firefox('<=50') ? fail : pass,
       'string_case_test_01_multi': firefox_fail,
       'string_fromcharcodes_test': skip_timeout,
       'string_operations_with_null_test': fail,
+      'string_split_test': whitelist,
       'symbol_reserved_word_test_06_multi': fail,
       'symbol_reserved_word_test_09_multi': fail,
       'symbol_reserved_word_test_12_multi': fail,
       'throw_half_surrogate_pair_test_01_multi': fail,
       'unicode_test': firefox_fail,
       'uri_parameters_all_test': is.firefox('<=50') ? fail : pass,
       // TODO(rnystrom): Times out because it tests a huge number of
       // combinations of URLs (4 * 5 * 5 * 8 * 6 * 6 * 4 = 115200).
       'uri_parse_test': skip_timeout,
       'uri_test': 'slow',
 
       'list_insert_test': fail,
       'list_removeat_test': fail,
     },
 
     'corelib/regexp': {
       'default_arguments_test': fail,
       'UC16_test': firefox_fail,
     },
 
     'lib/collection': {
+      'linked_list_test': whitelist,
     },
 
     'lib/convert': {
       'base64_test_01_multi': 'slow',
-      'chunked_conversion_utf85_test': 'slow',
+      'chunked_conversion_utf82_test': whitelist,
+      'chunked_conversion_utf83_test': whitelist,
+      'chunked_conversion_utf85_test': ['whitelist', 'slow'],
+      'chunked_conversion_utf86_test': whitelist,
+      'chunked_conversion_utf87_test': whitelist,
 
       'encoding_test': skip_timeout,
 
       'json_utf8_chunk_test': skip_timeout,
       'latin1_test': skip_timeout,
 
+      'streamed_conversion_json_decode1_test': whitelist,
       'streamed_conversion_json_encode1_test': skip_timeout,
       'streamed_conversion_json_utf8_decode_test': skip_timeout,
       'streamed_conversion_json_utf8_encode_test': skip_timeout,
       'streamed_conversion_utf8_decode_test': skip_timeout,
       'streamed_conversion_utf8_encode_test': skip_timeout,
+      'utf82_test': whitelist,
       'utf85_test': skip_timeout,
+      'utf8_encode_test': whitelist,
+      'utf8_test': whitelist,
     },
 
     'lib/html': {
       'async_spawnuri_test': async_unittest,
       'async_test': async_unittest,
 
        // was https://github.com/dart-lang/sdk/issues/27578, needs triage
       'audiocontext_test': is.chrome('<=54') ? fail : pass,
 
       'canvas_test': ['unittest'],
@@ skipping 107 matching lines @@
       'pi_test': skip_timeout,
       'random_big_test': fail,
     },
 
     'lib/typed_data': {
       // No bigint or int64 support
       'int32x4_bigint_test': fail,
       'int64_list_load_store_test': fail,
       'typed_data_hierarchy_int64_test': fail,
       'typed_data_list_test': fail,
+      'typed_list_iterable_test': whitelist,
     },
 
     'lib/mirrors': {
       'abstract_class_test_none_multi': fail,
       'accessor_cache_overflow_test': fail,
       'array_tracing3_test': fail,
       'array_tracing_test': fail,
       'basic_types_in_dart_core_test': fail,
       'circular_factory_redirection_test_none_multi': fail,
       'class_mirror_location_test': fail,
@@ skipping 226 matching lines @@
         // 6. Hangs.  In this case, we rely on the underlying mocha framework
         //    timeout.
         //
         // TODO(vsm): This currently doesn't handle tests that trigger multiple
         // asynchronous exceptions.
 
         let mainLibrary = require(module)[libraryName(name)];
         let negative = /negative_test/.test(name);
         let fail = has('fail');
 
+        let whitelist = has('whitelist');
+        dart_sdk.dart.ignoreWhitelistedErrors(whitelist);
+
         function finish(error) {
           // If the test left any lingering detritus in the DOM, blow it away
           // so it doesn't interfere with later tests.
           if (fail) {
             if (negative) {
               if (error) {
                 error = new Error(
                   "negative test marked as 'fail' " +
                   "but passed by throwing:\n" + error);
               }
             } else if (error) {
               error = null
             } else {
               error = new Error("test marked as 'fail' but passed");
             }
           } else if (negative) {
             if (!error) {
               error = new Error("test marked as 'negative' but did not throw");
             } else {
               error = null;
             }
           }
           minitest.finishTests();
           document.body.innerHTML = '';
           console.log("cleared");
           if (error && !(error instanceof Error)) error = new Error(error);
+          dart_sdk.dart.ignoreWhitelistedErrors(false);
           done(error);
         }
 
         // Intercept uncaught exceptions
         window.onerror = function(message, url, line, column, error) {
           console.warn('Asynchronous error in ' + name + ': ' + message);
           if (!error) {
             error = new Error(message);
           }
           finish(error);
@@ skipping 28 matching lines @@
       });
     }
   }
 
   // We run these tests in a mocha test wrapper to avoid the confusing failure
   // case of dart unittests being interleaved with mocha tests.
   // In practice we are really just suppressing all mocha test behavior while
   // Dart unittests run and then re-enabling it when the dart tests complete.
   html_config.useHtmlConfiguration();
   test('run all dart unittests', function(done) { // 'function' to allow `this.timeout`
+    // Use the whitelist for all unittests - there may be an error in the framework
+    // itself.
+    dart_sdk.dart.ignoreWhitelistedErrors(whitelist);
     if (unittest_tests.length == 0) return done();
 
     // TODO(vsm): We're using an old deprecated version of unittest.
     // We need to migrate all tests (in the SDK itself) off of
     // unittest.
 
     // All unittests need to be explicitly marked as such above.  If
     // not, the unittest framework will be run in a 'normal' test and
     // left in an inconsistent state at this point triggering spurious
     // failures.  This check ensures we're not in such a state.  If it fails,
@@ skipping 35 matching lines @@
 
     for (let action of unittest_tests) {
       try {
         action();
       } catch (e) {
         console.error("Caught error tying to setup test:", e);
       }
     }
   });
 });