Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2739853002: Fix FreeType component build on Fedora (Closed)

Created:
3 years, 9 months ago by drott
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix FreeType component build on Fedora BUG=698763 Review-Url: https://codereview.chromium.org/2739853002 Cr-Commit-Position: refs/heads/master@{#455455} Committed: https://chromium.googlesource.com/chromium/src/+/2c656e7549443124d7c13dce0b808a1f19cd0df4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M third_party/freetype/BUILD.gn View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 21 (11 generated)
drott
3 years, 9 months ago (2017-03-08 09:45:39 UTC) #4
Raphael Kubo da Costa (rakuco)
I was applying a similar fix locally, so I can confirm it works for me ...
3 years, 9 months ago (2017-03-08 09:58:35 UTC) #5
Raphael Kubo da Costa (rakuco)
non-owner lgtm, to be clear :-)
3 years, 9 months ago (2017-03-08 13:32:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739853002/1
3 years, 9 months ago (2017-03-08 13:33:38 UTC) #10
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 9 months ago (2017-03-08 13:33:40 UTC) #12
drott
Dirk, or Ben, could you please review this? Thanks.
3 years, 9 months ago (2017-03-08 13:50:56 UTC) #14
bungeman-chromium
I have no issue with it. lgtm
3 years, 9 months ago (2017-03-08 14:55:28 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739853002/1
3 years, 9 months ago (2017-03-08 14:56:08 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2c656e7549443124d7c13dce0b808a1f19cd0df4
3 years, 9 months ago (2017-03-08 15:27:59 UTC) #20
Dirk Pranke
3 years, 9 months ago (2017-03-08 21:08:53 UTC) #21
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698