Issue 273983002: Keep base direction 'ltr' for entry names consistently.

Issue 273983002: Keep base direction 'ltr' for entry names consistently. (Closed)

Created:
6 years, 7 months ago by fukino

Modified:
6 years, 7 months ago

Reviewers:
yoshiki

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Keep base direction 'ltr' for entry names consistently. In RTL languages, entry names (file names, directory names, volume names,...) look strange around the neutral characters (' ', '.', ')'...). This can be avoided by keeping base direction of bidi algorithm 'ltr' consistently and it is same behavior as Windows 8. BUG=371232 TEST=manually tested Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269551

Patch Set 1 #

Patch Set 2 : Use single quotation for css files. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -5 lines)			Patch
M	ui/file_manager/file_manager/foreground/css/common.css	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	ui/file_manager/file_manager/foreground/js/directory_tree.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/file_manager/file_manager/foreground/js/file_manager.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/file_manager/file_manager/foreground/js/file_table.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/file_manager/file_manager/foreground/js/ui/breadcrumbs_controller.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/file_manager/file_manager/foreground/js/ui/navigation_list.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/file_manager/file_manager/main.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

fukino

Sorry! I used double quotation in css selector, so updated the patch.

6 years, 7 months ago (2014-05-09 05:07:07 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/273983002/20001

6 years, 7 months ago (2014-05-09 07:09:05 UTC) #5

Message was sent while issue was closed.

Change committed as 269551

Expand Messages | Collapse Messages