Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: chrome/browser/extensions/content_verifier_browsertest.cc

Issue 2739823003: Disable ContentVerifierTest.FailOnDone and ContentVerifierTest.FailOnRead on Win 10 with PlzNavigat… (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/content_verifier_browsertest.cc
diff --git a/chrome/browser/extensions/content_verifier_browsertest.cc b/chrome/browser/extensions/content_verifier_browsertest.cc
index 0f36164d7acacd6eda8e02866bf088ed7ff40124..f7168b238d1a9a2e60672cf327aa08e406d660c2 100644
--- a/chrome/browser/extensions/content_verifier_browsertest.cc
+++ b/chrome/browser/extensions/content_verifier_browsertest.cc
@@ -22,6 +22,7 @@
#include "chrome/common/chrome_switches.h"
#include "components/policy/core/browser/browser_policy_connector.h"
#include "components/policy/core/common/mock_configuration_policy_provider.h"
+#include "content/public/common/browser_side_navigation_policy.h"
#include "content/public/test/test_utils.h"
#include "extensions/browser/content_verifier.h"
#include "extensions/browser/content_verify_job.h"
@@ -37,6 +38,10 @@
#include "extensions/browser/updater/manifest_fetch_data.h"
#include "extensions/common/extension_urls.h"
+#if defined(OS_WIN)
+#include "base/win/windows_version.h"
+#endif
+
namespace extensions {
namespace {
@@ -500,6 +505,13 @@ class ContentVerifierTest : public ExtensionBrowserTest {
};
IN_PROC_BROWSER_TEST_F(ContentVerifierTest, FailOnRead) {
+#if defined(OS_WIN)
+ if (content::IsBrowserSideNavigationEnabled() &&
+ base::win::GetVersion() >= base::win::VERSION_WIN10) {
+ // http://crbug.com/699437
+ return;
+ }
+#endif
EXPECT_EQ(0, delegate_.bytes_read_failed());
delegate_.fail_next_read();
OpenPageAndWaitForUnload();
@@ -507,6 +519,13 @@ IN_PROC_BROWSER_TEST_F(ContentVerifierTest, FailOnRead) {
}
IN_PROC_BROWSER_TEST_F(ContentVerifierTest, FailOnDone) {
+#if defined(OS_WIN)
+ if (content::IsBrowserSideNavigationEnabled() &&
+ base::win::GetVersion() >= base::win::VERSION_WIN10) {
+ // http://crbug.com/699437
+ return;
+ }
+#endif
EXPECT_EQ(0, delegate_.done_reading_failed());
delegate_.fail_next_done();
OpenPageAndWaitForUnload();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698