Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3202)

Unified Diff: ash/wm/window_modality_controller_unittest.cc

Issue 2739703003: Last sets of tests that can move to common_unittests (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/window_modality_controller_unittest.cc
diff --git a/ash/wm/window_modality_controller_unittest.cc b/ash/wm/window_modality_controller_unittest.cc
index e07be1b6a14601d9924011f3041c470cd16dd7a3..c76ce3ef77c4e782d4f0f4d4dc0415227233b79a 100644
--- a/ash/wm/window_modality_controller_unittest.cc
+++ b/ash/wm/window_modality_controller_unittest.cc
@@ -473,7 +473,7 @@ TEST_F(WindowModalityControllerTest, ChildModal) {
delegate->ShowChild();
aura::Window* child = delegate->GetChild();
- EXPECT_NE(static_cast<aura::Window*>(NULL), child);
sky 2017/03/07 20:56:10 I changed this single line as this test was failin
msw 2017/03/07 21:36:01 Acknowledged.
+ EXPECT_NE(nullptr, child);
EXPECT_TRUE(wm::IsActiveWindow(child));
EXPECT_FALSE(wm::IsActiveWindow(modal_parent));

Powered by Google App Engine
This is Rietveld 408576698