Issue 2739703002: Revert "Add test for cancel-future being awaited after an `await for`."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2739703002: Revert "Add test for cancel-future being awaited after an `await for`." (Closed)

Created:
3 years, 9 months ago by Alan Knight

Modified:
3 years, 9 months ago

Reviewers:
Lasse Reichstein Nielsen, floitsch

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Add test for cancel-future being awaited after an `await for`." This reverts commit 74a8351fb6ccb6789c9195a4b4905d853090d4e7. BUG= Committed: https://github.com/dart-lang/sdk/commit/1b96ec4857af0fb42857a7a22e944b8c590ec192

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -86 lines)			Patch
M	tests/language/await_for_test.dart	View	2 chunks	+34 lines, -82 lines	0 comments	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/language/language_kernel.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Alan Knight

Committed patchset #1 (id:1) manually as 1b96ec4857af0fb42857a7a22e944b8c590ec192 (presubmit successful).

3 years, 9 months ago (2017-03-07 19:24:55 UTC) #4

Lasse Reichstein Nielsen

3 years, 9 months ago (2017-03-07 19:58:55 UTC) #5

Message was sent while issue was closed.

Doh, should have said "Fail, Crash" just to be safe.

LGTM and thanks