Handle recursive list structures in debugger

runtime/bin/dbg_message.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/dbg_connection.h"
 #include "bin/dbg_message.h"
 #include "bin/dartutils.h"
 #include "bin/thread.h"
 #include "bin/utils.h"
 
@@ skipping 149 matching lines @@
 
 static void FormatEncodedString(dart::TextBuffer* buf, Dart_Handle str) {
   buf->AddChar('\"');
   FormatEncodedChars(buf, str);
   buf->AddChar('\"');
 }
 
 
 static void FormatTextualValue(dart::TextBuffer* buf,
                                Dart_Handle object,
-                               intptr_t max_chars);
+                               intptr_t max_chars,
+                               bool expand_list);
 
 
 static void FormatTextualListValue(dart::TextBuffer* buf,
                                    Dart_Handle list,
                                    intptr_t max_chars) {
   intptr_t len = 0;
   Dart_Handle res = Dart_ListLength(list, &len);
   ASSERT_NOT_ERROR(res);
   const intptr_t initial_buffer_length = buf->length();
   // Maximum number of characters we print for array elements.
   const intptr_t max_buffer_length = initial_buffer_length + max_chars;
   buf->Printf("[");
   for (int i = 0; i < len; i++) {
     if (i > 0) {
       buf->Printf(", ");
     }
     Dart_Handle elem = Dart_ListGetAt(list, i);
     const intptr_t max_element_chars = 50;
-    FormatTextualValue(buf, elem, max_element_chars);
+    FormatTextualValue(buf, elem, max_element_chars, false);
     if (buf->length() > max_buffer_length) {
       buf->Printf(", ...");
       break;
     }
   }
   buf->Printf("]");
 }
 
 
 static void FormatTextualValue(dart::TextBuffer* buf,
                                Dart_Handle object,
-                               intptr_t max_chars) {
+                               intptr_t max_chars,
+                               bool expand_list) {
   if (Dart_IsList(object)) {
-    FormatTextualListValue(buf, object, max_chars);
+    if (expand_list) {
+      FormatTextualListValue(buf, object, max_chars);
+    } else {
+      buf->Printf("[...]");
+    }
   } else if (Dart_IsNull(object)) {
     buf->Printf("null");
   } else if (Dart_IsString(object)) {
     buf->Printf("\\\"");
     FormatEncodedCharsTrunc(buf, object, max_chars);
     buf->Printf("\\\"");
   } else {
     Dart_Handle text = Dart_ToString(object);
     if (Dart_IsNull(text)) {
       buf->Printf("null");
@@ skipping 21 matching lines @@
   } else {
     buf->Printf("\"kind\":\"object\",");
     intptr_t class_id = 0;
     Dart_Handle res = Dart_GetObjClassId(object, &class_id);
     if (!Dart_IsError(res)) {
       buf->Printf("\"classId\":%" Pd ",", class_id);
     }
   }
   buf->Printf("\"text\":\"");
   const intptr_t max_chars = 250;
-  FormatTextualValue(buf, object, max_chars);
+  FormatTextualValue(buf, object, max_chars, true);
   buf->Printf("\"");
 }
 
 
 static void FormatValueObj(dart::TextBuffer* buf, Dart_Handle object) {
   buf->Printf("{");
   FormatValue(buf, object);
   buf->Printf("}");
 }
 
@@ skipping 1044 matching lines @@
     } else {
       ASSERT(kind == kShutdown);
       RemoveIsolateMsgQueue(isolate_id);
     }
   }
   Dart_ExitScope();
 }
 
 }  // namespace bin
 }  // namespace dart