third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.cc - Issue 2739683006: Use Opportunity Iterator to position text fragments in NGLineBuilder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.cc

Issue 2739683006: Use Opportunity Iterator to position text fragments in NGLineBuilder (Closed)

Patch Set: add font-family Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_line_builder.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.cc b/third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.cc

index ab37fecc93bdd4b124e68615ef51c9937c414861..ec6a20397700fad74786182643af320bd6c200b9 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.cc

@@ -9,6 +9,7 @@

#include "core/layout/ng/ng_constraint_space.h"

#include "core/layout/ng/ng_fragment_builder.h"

#include "core/layout/ng/ng_inline_node.h"

+#include "core/layout/ng/ng_layout_opportunity_iterator.h"

#include "core/layout/ng/ng_line_builder.h"

#include "core/layout/ng/ng_text_fragment.h"

#include "core/style/ComputedStyle.h"

@@ -72,6 +73,8 @@ void NGTextLayoutAlgorithm::LayoutInline(NGLineBuilder* line_builder) {

// If there are more available spaces, mark the break opportunity and fetch

// more text.

+ // TODO(layout-ng): check if the height of the linebox can fit within

+ // the current opportunity.

if (line_builder->CanFitOnLine()) {

line_builder->SetBreakOpportunity();

continue;