Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

Issue 2739683006: Use Opportunity Iterator to position text fragments in NGLineBuilder (Closed)
Patch Set: add font-family Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc
index c9648b95913e913201f0f01288327c53523381ac..2d850cc959279d0993a3e210e9342b82b3b5587c 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc
@@ -8,6 +8,7 @@
#include "core/dom/TagCollection.h"
#include "core/layout/LayoutTestHelper.h"
#include "core/layout/ng/layout_ng_block_flow.h"
+#include "core/layout/ng/ng_base_layout_algorithm_test.h"
#include "core/layout/ng/ng_block_break_token.h"
#include "core/layout/ng/ng_block_node.h"
#include "core/layout/ng/ng_constraint_space.h"
@@ -18,7 +19,6 @@
#include "core/layout/ng/ng_physical_fragment.h"
#include "core/style/ComputedStyle.h"
#include "testing/gmock/include/gmock/gmock.h"
-#include "testing/gtest/include/gtest/gtest.h"
namespace blink {
namespace {
@@ -48,25 +48,11 @@ RefPtr<NGConstraintSpace> ConstructConstraintSpace(
.ToConstraintSpace(writing_mode);
}
-typedef bool TestParamLayoutNG;
-class NGBlockLayoutAlgorithmTest
- : public ::testing::WithParamInterface<TestParamLayoutNG>,
- public RenderingTest {
- public:
- NGBlockLayoutAlgorithmTest() {
- RuntimeEnabledFeatures::setLayoutNGEnabled(true);
- RuntimeEnabledFeatures::setLayoutNGInlineEnabled(true);
- }
- ~NGBlockLayoutAlgorithmTest() {
- RuntimeEnabledFeatures::setLayoutNGEnabled(false);
- RuntimeEnabledFeatures::setLayoutNGInlineEnabled(false);
- }
-
+class NGBlockLayoutAlgorithmTest : public NGBaseLayoutAlgorithmTest {
protected:
void SetUp() override {
+ NGBaseLayoutAlgorithmTest::SetUp();
style_ = ComputedStyle::create();
- RenderingTest::SetUp();
- enableCompositing();
}
RefPtr<NGPhysicalBoxFragment> RunBlockLayoutAlgorithm(
@@ -78,20 +64,6 @@ class NGBlockLayoutAlgorithmTest
return toNGPhysicalBoxFragment(result->PhysicalFragment().get());
}
- std::pair<RefPtr<NGPhysicalBoxFragment>, RefPtr<NGConstraintSpace>>
- RunBlockLayoutAlgorithmForElement(Element* element) {
- LayoutNGBlockFlow* block_flow =
- toLayoutNGBlockFlow(element->layoutObject());
- NGBlockNode* node = new NGBlockNode(block_flow);
- RefPtr<NGConstraintSpace> space =
- NGConstraintSpace::CreateFromLayoutObject(*block_flow);
-
- RefPtr<NGLayoutResult> result =
- NGBlockLayoutAlgorithm(node, space.get()).Layout();
- return std::make_pair(
- toNGPhysicalBoxFragment(result->PhysicalFragment().get()), space);
- }
-
MinMaxContentSize RunComputeMinAndMax(NGBlockNode* node) {
// The constraint space is not used for min/max computation, but we need
// it to create the algorithm.

Powered by Google App Engine
This is Rietveld 408576698