Use Opportunity Iterator to position text fragments in NGLineBuilder

third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_offset.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/ng/geometry/ng_logical_offset.h"
 
 #include "core/layout/ng/geometry/ng_physical_offset.h"
 #include "core/layout/ng/geometry/ng_physical_size.h"
 #include "wtf/text/WTFString.h"
 
@@ skipping 38 matching lines @@
       ASSERT_NOT_REACHED();
       return NGPhysicalOffset();
   }
 }
 
 bool NGLogicalOffset::operator==(const NGLogicalOffset& other) const {
   return std::tie(other.inline_offset, other.block_offset) ==
          std::tie(inline_offset, block_offset);
 }
 
+bool NGLogicalOffset::operator!=(const NGLogicalOffset& other) const {
+  return std::tie(other.inline_offset, other.block_offset) !=

[ikilpatrick, 2017/03/09 22:00:51]

just "return !operator==(other);" ?

[Gleb Lanbin, 2017/03/09 22:26:44]

nice, thanks!

+         std::tie(inline_offset, block_offset);
+}
+
 NGLogicalOffset NGLogicalOffset::operator+(const NGLogicalOffset& other) const {
   NGLogicalOffset result;
   result.inline_offset = this->inline_offset + other.inline_offset;
   result.block_offset = this->block_offset + other.block_offset;
   return result;
 }
 
 NGLogicalOffset& NGLogicalOffset::operator+=(const NGLogicalOffset& other) {
   *this = *this + other;
   return *this;
@@ skipping 31 matching lines @@
 
 String NGLogicalOffset::ToString() const {
   return String::format("%dx%d", inline_offset.toInt(), block_offset.toInt());
 }
 
 std::ostream& operator<<(std::ostream& os, const NGLogicalOffset& value) {
   return os << value.ToString();
 }
 
 }  // namespace blink