Fix friendly frame parsing bugs.

test/frame_test.dart

Index: test/frame_test.dart
diff --git a/test/frame_test.dart b/test/frame_test.dart
index 080c8b8ed5003d3783f2c119bfbaf5d7b91d7211..a5f8b234469e925e8a2250604f2ecbb3c9342e61 100644
--- a/test/frame_test.dart
+++ b/test/frame_test.dart
@@ -448,7 +448,7 @@ void main() {
       expect(frame.member, equals('Foo.<fn>.bar'));
     });
 
-    test('parses a stack frame with no line correctly', () {
+    test('parses a stack frame with no column correctly', () {
       var frame = new Frame.parseFriendly(
           "http://dartlang.org/foo/bar.dart 10  Foo.<fn>.bar");
       expect(frame.uri, equals(Uri.parse("http://dartlang.org/foo/bar.dart")));
@@ -472,6 +472,45 @@ void main() {
       expectIsUnparsed((text) => new Frame.parseFriendly(text),
           'foo/bar.dart 10:11');
     });
+
+    test('parses a data url stack frame with no line or column correctly', () {
+      var frame = new Frame.parseFriendly(
+          "data:...  main");
+      expect(frame.uri.scheme, equals('data'));
+      expect(frame.line, isNull);
+      expect(frame.column, isNull);
+      expect(frame.member, equals('main'));
+    });
+
+    test('parses a data url stack frame correctly', () {
+      var frame = new Frame.parseFriendly(
+          "data:... 10:11    main");
+      expect(frame.uri.scheme, equals('data'));
+      expect(frame.line, equals(10));
+      expect(frame.column, equals(11));
+      expect(frame.member, equals('main'));
+    });
+
+    test('parses a stack frame with spaces in the member name correctly', () {
+      var frame = new Frame.parseFriendly(
+          "foo/bar.dart 10:11    (anonymous function).dart.fn");

[nweiz, 2017/03/07 21:27:28]

Wherever this "(anonymous function)" frame is coming from originally (V8
parsing?), it should be converted to "<fn>". We normalize the various
implementation-specific representations of anonymous functions to that.

[Jacob, 2017/03/07 23:27:20]

Ot isn't because V8 has tweaked the strings they use to describe anonymous
functions. In Chrome Beta and probably elsewhere you can now get the string
(anonymous function) in addition to the existing patterns Anonymous function and
<anonymous>.
I've added a test to verify that case is now handled consistently replacing
(anonymous function) with <fn>
I'd still like to keep this test as odds are some browser will tweak their names
for anonymous functions again breaking this code again.

I can change this test from 
(anonymous function) to (unexpected function name) or something if you want to
make it clear that real world friendly stack traces are not expected to have
spaces in their names.

[nweiz, 2017/03/07 23:44:32]

SGTM
Probably not necessary.

+      expect(frame.uri,
+          equals(path.toUri(path.absolute(path.join('foo', 'bar.dart')))));
+      expect(frame.line, equals(10));
+      expect(frame.column, equals(11));
+      expect(frame.member, equals('(anonymous function).dart.fn'));
+    });
+
+    test('parses a stack frame with spaces in the member name and no line or '
+         'column correctly', () {
+      var frame = new Frame.parseFriendly(
+          "http://dartlang.org/foo/bar.dart  (anonymous function).dart.fn");
+      expect(
+          frame.uri, equals(Uri.parse("http://dartlang.org/foo/bar.dart")));
+      expect(frame.line, isNull);
+      expect(frame.column, isNull);
+      expect(frame.member, equals('(anonymous function).dart.fn'));
+    });
   });
 
   test('only considers dart URIs to be core', () {