Fix friendly frame parsing bugs.

lib/src/frame.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:path/path.dart' as path;
 
 import 'trace.dart';
 import 'unparsed_frame.dart';
 
 // #1      Foo._bar (file:///home/nweiz/code/stuff.dart:42:21)
@@ skipping 34 matching lines @@
       r'@'
     r')?'
     r'(.*?)' // The frame's URL.
     r':'
     r'(\d*)' // The line number. Empty in Safari if it's unknown.
     r'(?::(\d*))?' // The column number. Not present in older browsers and
                    // empty in Safari if it's unknown.
     r'$');
 
 // foo/bar.dart 10:11 Foo._bar
+// foo/bar.dart 10:11 (anonymous function).dart.fn
 // http://dartlang.org/foo/bar.dart Foo._bar
+// data:... 10:11 Foo._bar
 final _friendlyFrame = new RegExp(
-    r'^(\S+)(?: (\d+)(?::(\d+))?)?\s+([^\d]\S*)$');
+    r'^(\S+)(?: (\d+)(?::(\d+))?)?\s+([^\d].*)$');
 
 /// A regular expression that matches asynchronous member names generated by the
 /// VM.
 final _asyncBody = new RegExp(r'<(<anonymous closure>|[^>]+)_async_body>');
 
 final _initialDot = new RegExp(r"^\.");
 
 /// A single stack frame. Each frame points to a precise location in Dart code.
 class Frame {
   /// The URI of the file in which the code is located.
@@ skipping 174 matching lines @@
   /// Parses a string representation of a Safari stack frame.
   factory Frame.parseSafari(String frame) => new Frame.parseFirefox(frame);
 
   /// Parses this package's string representation of a stack frame.
   factory Frame.parseFriendly(String frame) => _catchFormatException(frame, () {
     var match = _friendlyFrame.firstMatch(frame);
     if (match == null) {
       throw new FormatException(
           "Couldn't parse package:stack_trace stack trace line '$frame'.");
     }
-
-    var uri = Uri.parse(match[1]);
+    // Fake truncated data urls generated by the friendly stack trace format
+    // cause Uri.parse to throw an exception so we have to special case them.
+    var uri = match[1] == 'data:...'
+        ? new Uri.dataFromString('...')

[nweiz, 2017/03/07 21:27:28]

Maybe just pass this an empty string. I think that better represents "we don't
know the data this contains".

[Jacob, 2017/03/07 23:27:20]

Done.

+        : Uri.parse(match[1]);
     // If there's no scheme, this is a relative URI. We should interpret it as
     // relative to the current working directory.
     if (uri.scheme == '') {
       uri = path.toUri(path.absolute(path.fromUri(uri)));
     }
 
     var line = match[2] == null ? null : int.parse(match[2]);
     var column = match[3] == null ? null : int.parse(match[3]);
     return new Frame(uri, line, column, match[4]);
   });
@@ skipping 31 matching lines @@
       return body();
     } on FormatException catch (_) {
       return new UnparsedFrame(text);
     }
   }
 
   Frame(this.uri, this.line, this.column, this.member);
 
   String toString() => '$location in $member';
 }